mise: drop windows_default_inline_shell_args from repo config - #10056
Closed
calebdw wants to merge 1 commit into
Closed
mise: drop windows_default_inline_shell_args from repo config#10056calebdw wants to merge 1 commit into
calebdw wants to merge 1 commit into
Conversation
`mise` marks shell-argument settings as global-only and strips them from
any non-global config at parse time, since they are a code execution
vector. This happens on every platform, so the setting never took
effect for Windows contributors either; all it did was print a warning
on every `mise` invocation in the repo:
mise WARN windows_default_inline_shell_args in non-global config
/path/to/jj/.config/mise.toml is ignored for security reasons
`mise` has no per-task or per-config way to select a shell only on
Windows (`shell` applies to all platforms), so document the global
setting in the contributing guide instead. That is the only place
`mise` will honor it.
Contributor
|
this is a dup of #10047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
misemarks shell-argument settings as global-only and strips them from any non-global config at parse time, since they are a code execution vector. This happens on every platform, so the setting never took effect for Windows contributors either; all it did was print a warning on everymiseinvocation in the repo:misehas no per-task or per-config way to select a shell only on Windows (shellapplies to all platforms), so document the global setting in the contributing guide instead. That is the only placemisewill honor it.